Fix build with clang v15.0.6 [-Wunused-but-set-variable] #1247
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
squid-anubis
added
the
M-failed-description
rousskov
changed the title
squid-anubis
removed
the
M-failed-description
rousskov
approved these changes
Jan 25, 2023
There was a problem hiding this comment.
If this change fixes Squid build somewhere, please update PR title/description accordingly (e.g., see #1246).
I polished PR title, primarily to highlight that this is a code maintenance change (i.e. it does not affect Squid functionality). I removed PR description to fix its formatting -- the PR title now contains essentially the same info. Please review and adjust further as needed.
FWIW, I recommend avoiding key: text PR title format except for a few commonly used keys like Maintenance, Bug NNN, Docs, Language, and CI. Having a small set of commit title keys helps navigating regular git log output. On the other hand, using function names as keys is just a distraction/noise -- folks searching for function X changes will use git log -L... or similar tools tailored for that purpose.
squid-anubis
added
the
M-failed-description
rousskov
changed the title
squid-anubis
removed
the
M-failed-description
rousskov
added
the
M-cleared-for-merge
squid-anubis
pushed a commit
that referenced
this pull request
Jan 27, 2023
clang v15.0.6 distributed with Fedora Rawhide complains about a variable
that is updated but never used:
net_db.cc:230:9: error: variable 'removed' set but not used
[-Werror,-Wunused-but-set-variable]`
squid-anubis
added
the
M-waiting-staging-checks
squid-anubis
added
M-merged
squidadm
pushed a commit
to squidadm/squid
that referenced
this pull request
Feb 23, 2023
…#1247) clang v15.0.6 distributed with Fedora Rawhide complains about a variable that is updated but never used: net_db.cc:230:9: error: variable 'removed' set but not used [-Werror,-Wunused-but-set-variable]`
yadij
pushed a commit
that referenced
this pull request
Feb 23, 2023
clang v15.0.6 distributed with Fedora Rawhide complains about a variable
that is updated but never used:
net_db.cc:230:9: error: variable 'removed' set but not used
[-Werror,-Wunused-but-set-variable]`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
clang v15.0.6 distributed with Fedora Rawhide complains about a variable
that is updated but never used: